Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change the type of authnRequestNameIDFormat from Text to NameIDFormat #41

Merged
merged 1 commit into from
Feb 2, 2023
Merged

change the type of authnRequestNameIDFormat from Text to NameIDFormat #41

merged 1 commit into from
Feb 2, 2023
+24 −5

Conversation

fumieval
Copy link
Contributor

@fumieval fumieval commented Feb 2, 2023

Checklist

  • All definitions are documented with Haddock-style comments.
  • All exported definitions have @since annotations.
  • Code is formatted in line with the existing code.
  • The changelog has been updated.

@github-actions github-actions bot requested a review from mbg February 2, 2023 07:13
mbg
mbg approved these changes Feb 2, 2023
View reviewed changes
Copy link
Owner

@mbg mbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I added one comment, but you don't need to act on it and I will merge this as is.

CHANGELOG.md
@@ -8,6 +8,7 @@
* Add new module `Network.Wai.SAML2.Request` with `AuthnRequest` generation for SP-initiated login flow ([#19](https://github.com/mbg/wai-saml2/pull/19) by [@fumieval](https://github.com/fumieval))
* Changed the `saml2PrivateKey` field to be optional and added `saml2ConfigNoEncryption` which takes a `PublicKey` only
* Added `showUTCTime` to `Network.Wai.SAML2.XML`
* Added a new module `Network.Wai.SAML2.NameIDFormat`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't descriptive enough for the changelog, but this wasn't introduced by this PR in any case so don't worry about it. I will edit this later on when I prepare the release.

@mbg mbg merged commit cb97399 into mbg:master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbg mbg mbg approved these changes

Assignees

@fumieval fumieval

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fumieval @mbg