Fix memoized method subjects to preserve freezer option #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mbj Ready for review. I see CI is failing integration tests but I'm not sure if you need me to recurse into these. |
|
@snusnu Code wise I'm fine, but the CI rusted. Hence it has to be fixed first. |
snusnu
force-pushed
the
change/preserve-adamantium-freezer-option
branch
4 times, most recently
from
92310a8
to
b194e4c
Compare
1 task
snusnu
force-pushed
the
change/preserve-adamantium-freezer-option
branch
from
b194e4c
to
ad6657b
Compare
mbj
force-pushed
the
change/preserve-adamantium-freezer-option
branch
from
151a7c9
to
18f070d
Compare
mbj
previously approved these changes
Jan 1, 2020
snusnu
force-pushed
the
change/preserve-adamantium-freezer-option
branch
from
29ca4d4
to
34c3baa
Compare
mbj
force-pushed
the
change/preserve-adamantium-freezer-option
branch
from
c430ab8
to
a06b0c3
Compare
* If Memoizable alone is included in the subject scope, #memoize does not support any options. * Adamantium extends Memoizable by adding support for configuring the freezer to be used as an option for #memoize. * If Adamantium is included in the subject scope, the freezer that was either used implicitly or configured explicitly, needs to be preserved to keep original semantics intact. * The AST generated for the call to #memoize exhibits semantics that are equivalent to the originally defined memoizer. It may not always lead to identical source when being unparsed though. This is because memoizable provides no API to reflect on whether the freezer was configured implicitly by the adamantium module or whether it was set explicitly via the :freezer option added by adamantium.
mbj
force-pushed
the
change/preserve-adamantium-freezer-option
branch
from
f1ff55d
to
1d2c654
Compare
mbj
reviewed
Aug 24, 2020
| @@ -137,7 +153,7 @@ def foo; end | |||
| it_should_behave_like 'a command method' | |||
| end | |||
|
|
|||
| describe '#mutations', mutant_expression: 'Mutant::Subject#mutations' do | |||
| describe '#mutations' do | |||
There was a problem hiding this comment.
@snusnu The fix for the last alive mutation was removing this overly specific overwrite!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #639