Add logged in user, logout link #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required returning a Promise from `urlp.loadApp`, since we're fetching the user ID asynchronously. If network overhead is ever an issue, we can consider rendering index.html as a template, or sending back the logged-in user in an HTTP header.
While experimenting with new end-to-end test cases, I realized that calling `driver.close()` would actually end the Chrome session.
Forgot that PhantomJS can't parse them.
1 similar comment
|
Not really sure why it's reporting less coverage. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required returning a Promise from
urlp.loadApp, since we're fetching the user ID asynchronously. If network overhead is ever an issue, we can consider rendering index.html as a template, or sending back the logged-in user in an HTTP header.Also, while experimenting with new end-to-end test cases, I realized that calling
driver.close()would actually end the Chrome session, so the second commit removes that call fromafterEach.