BUGFIX: allow you to seed data that has an id < 1 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the id sequence to an invalid id
| "(SELECT MAX(#{quoted_id}) FROM #{@model_class.quoted_table_name}) + 1" + | ||
| ");" | ||
| ) | ||
| next_id = (@model_class.maximum(:id) || 0) + 1 |
There was a problem hiding this comment.
I think this will introduce race condition errors. There can be an insert between this line and updating sequence so we will change sequence value to wrong one. I think we can achieve the same using
"SELECT pg_catalog.setval(" +
"#{quoted_sequence}," +
"(SLECT MAX(#{quoted_id}) FROM #{@model_class.quoted_table_name} where #{quoted_id} > 0) + 1" +
");"
|
can you add tests for your pull requests? |
|
@aserafin added spec and fixed specs in rails 4, its not a new concurrency concern, if you want absolute safety you would need a serialized transaction. |
aserafin
added a commit
that referenced
this pull request
Jun 16, 2014
* commit 'refs/pull/origin/54': Failing test in DB=postgresql fix specs in Rails 4 use rspec add rake file BUGFIX: if you seed data that has an id < 1 seed-fu attempts to reset the id sequence to an invalid id Conflicts: lib/seed-fu/seeder.rb spec/spec_helper.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow you to seed data that has an id < 1 in postgres
prior to this seed-fu attempts to repair the id sequence with an invalid id