Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There's nothing here? #1

Closed
mblomdahl opened this issue Mar 23, 2019 · 0 comments · Fixed by #2
Closed

There's nothing here? #1

mblomdahl opened this issue Mar 23, 2019 · 0 comments · Fixed by #2

Comments

@mblomdahl
Copy link
Owner

Mats, can you please add some basic structure to the project? A Python package, unit test scaffolding, et cetera.

mblomdahl added a commit that referenced this issue Mar 23, 2019
… together, and update README with instructions on how to use it for contributing
ghost pushed a commit to mkdevops-se/gateway that referenced this issue Oct 23, 2019
- Moved dir `./project/models -> ./gateway/models`
- Moved dir `./project/resources -> ./gateway/resources`
- Moved file `./project/__init__.py -> ./gateway/__init__.py`
- Moved file `./app.py -> ./gateway/app.py`
- Moved file `./db.py -> ./gateway/db.py`
- Correct `gateway` import paths for `./tests/conftest.py`
- Corrected import paths and then commented-out not-working tests in
  `./tests`:
  - `test_firebase_model.py`
  - `test_firebase_resource.py`
  - `test_models.py`
- Added 2 simple tests in `./tests/test_the_simplest_thing.py`
- Added *Contributing* section to README, from mblomdahl/qsck#1
- Updated `setup.py` with
  - correct spelling
  - target package `gateway`
  - `setup_requires` and `install_requires` attributes
akebrissman added a commit to akebrissman/gateway that referenced this issue Nov 14, 2021
* Initial commit.

* Changes after code review.

* Delete .gitignore

* Changes after code review.

* Added Setup files

* Added a top folder project
Added a test folder with unit test class

* Configured full path to the repo

* First try to add unit test for Firebase Resource and Firebase Model

* Added postman files to test the endpoints

* Added Pytest to the project.

* Added Pytest to the project.

* Correct package structure from PR #1

- Moved dir `./project/models -> ./gateway/models`
- Moved dir `./project/resources -> ./gateway/resources`
- Moved file `./project/__init__.py -> ./gateway/__init__.py`
- Moved file `./app.py -> ./gateway/app.py`
- Moved file `./db.py -> ./gateway/db.py`
- Correct `gateway` import paths for `./tests/conftest.py`
- Corrected import paths and then commented-out not-working tests in
  `./tests`:
  - `test_firebase_model.py`
  - `test_firebase_resource.py`
  - `test_models.py`
- Added 2 simple tests in `./tests/test_the_simplest_thing.py`
- Added *Contributing* section to README, from mblomdahl/qsck#1
- Updated `setup.py` with
  - correct spelling
  - target package `gateway`
  - `setup_requires` and `install_requires` attributes

* Fixing comments on PR #2

- Added tests that imports db and SQLAlchemy from gateway library
- Added pytest.mark.skip decorator in test_models.py instead of
  commenting it out
- Fixed direct import of SQLAlchemy

* Restructured the project by moving the app object and the database to outside the gateway project
Updated Postman error and the initialization of flask-sql-alchemy

* Added some test cases for FirebaseModel

* Organized the imports according to Pep-8 Import grouping.

* Improved the project by renaming flask-test.cfg to flask_cfg
Added test cases to reach 100% test coverage

* Added .travis file for tesing.

* Added shebang to the app.py file

* Cleanup and support for Python 3.8

- changed __repr__ and __srt__ to be more in line with best practices
- Used more specific exception in the exception handler
- Updated README.md about how to create virtual env in python 3.8
- Updated packages in requirements.txt

Co-authored-by: vtepliuk <victoria.tepliuk@gmail.com>
Co-authored-by: Mats Blomdahl <mats.blomdahl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant