Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build source distribution for pypi #14

Merged
merged 1 commit into from
Jun 25, 2022
Merged

Conversation

frebib
Copy link
Contributor

@frebib frebib commented Jun 24, 2022

Certain packaging options require the source distribution specifically
to be available on pypi and cannot use the binary distribution.

Signed-off-by: Joe Groocock jgroocock@cloudflare.com


Building with fpm fails because it requires a source distribution. Having this would mean I don't have reinvent the wheel and build a package from source: https://github.com/jordansissel/fpm/blob/788170598572ab2a9cb4d844575e3a9dab2ab467/lib/fpm/package/python.rb#L153

Certain packaging options require the source distribution specifically
to be available on pypi and cannot use the binary distribution.

Signed-off-by: Joe Groocock <jgroocock@cloudflare.com>
@mborsetti mborsetti merged commit 802b2f2 into mborsetti:main Jun 25, 2022
@coveralls
Copy link

coveralls commented Jun 25, 2022

Pull Request Test Coverage Report for Build 2556548064

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.889%

Totals Coverage Status
Change from base Build 2458360175: 0.0%
Covered Lines: 31
Relevant Lines: 34

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants