Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Koszalin Zegrze Airport (OSZ) and Franklin Municipal John Beverly Rose Airport (FKN) #15

Merged
merged 5 commits into from
Aug 5, 2022

Conversation

bc291
Copy link
Contributor

@bc291 bc291 commented Aug 2, 2022

  1. Add EPKZ icao for OSZ iata Koszalin Zegrze Airport, formerly EPKO,
  2. Add FKN iata for KFKN icao Franklin Municipal John Beverly Rose Airport

@bc291 bc291 changed the title Add OSZ and FKN airports Update Koszalin Zegrze Airport (OSZ) and FKN (Franklin Municipal John Beverly Rose Airport) Aug 2, 2022
@bc291 bc291 changed the title Update Koszalin Zegrze Airport (OSZ) and FKN (Franklin Municipal John Beverly Rose Airport) Update Koszalin Zegrze Airport (OSZ) and Franklin Municipal John Beverly Rose Airport (FKN) Aug 2, 2022
@bc291
Copy link
Contributor Author

bc291 commented Aug 2, 2022

Also, should we keep both EPKZ and EPKO for Koszalin? In that case tests fail.

@coveralls
Copy link

coveralls commented Aug 2, 2022

Pull Request Test Coverage Report for Build 2781327206

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.889%

Totals Coverage Status
Change from base Build 2771437827: 0.0%
Covered Lines: 31
Relevant Lines: 34

💛 - Coveralls

@mborsetti mborsetti merged commit 585b5ff into mborsetti:main Aug 5, 2022
@mborsetti
Copy link
Owner

Thanks for the contribution!

It appears that the correct ICAO Location Indicator for Koszalin is EPKZ even though it does not appear in SkyVector, which gets its data from ARINC. Unfortunately we do not support historical codes so an aerodrome can only have one indicator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants