Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed fields redefinition in watch mode loop #162

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

lorepanichi
Copy link
Contributor

Changes:

  • fields var is already set outside watch mode loop (either parsed from option or statically set). This can't be done more then once, since fields var will hold the parsed list and won't ever be recognized again as the str typed option. Furthermore It doesn't really need to be re-evalueted at every incident fetch occurence, in the loop.

@lorepanichi lorepanichi requested a review from mbovo as a code owner July 6, 2024 15:19
@mbovo mbovo merged commit 0f52425 into mbovo:main Jul 31, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants