Skip to content

Latest commit

 

History

History
51 lines (31 loc) · 3.14 KB

CONTRIBUTING.md

File metadata and controls

51 lines (31 loc) · 3.14 KB
Raw

Contributing Guidelines

The following is a set of guidelines for contributing to the Docker GOST image. We really appreciate that you are considering contributing!

Table Of Contents

Getting Started

Contributing

Code Guidelines

Getting Started

Follow our how to use this image guide to get the Docker image with GOST TLS up and running.

Contributing

Report a Bug

To report a bug, open an issue on GitHub with the label bug using the available bug report issue template. Please ensure the bug has not already been reported. If the bug is a potential security vulnerability, please report it using the security tag

Suggest a Feature or Enhancement

To suggest a feature or enhancement, please create an issue on GitHub with the label enhancement using the available feature request template. Please ensure the feature or enhancement has not already been suggested.

Open a Pull Request

  • Fork the repo, create a branch, implement your changes, add any relevant tests, submit a PR when your changes are tested and ready for review.
  • Fill in our pull request template.

Note: if you'd like to implement a new feature, please consider creating a feature request issue first to start a discussion about the feature.

Code Guidelines

Git Guidelines

  • Keep a clean, concise and meaningful git commit history on your branch (within reason), rebasing locally and squashing before submitting a PR.
  • If possible and/or relevant, use the Conventional Commits format when writing a commit message, so that changelogs can be automatically generated
  • Follow the guidelines of writing a good commit message as described here https://chris.beams.io/posts/git-commit/ and summarised in the next few points:
    • In the subject line, use the present tense ("Add feature" not "Added feature").
    • In the subject line, use the imperative mood ("Move cursor to..." not "Moves cursor to...").
    • Limit the subject line to 72 characters or less.
    • Reference issues and pull requests liberally after the subject line.
    • Add more detailed description in the body of the git message (git commit -a to give you more space and time in your text editor to write a good message instead of git commit -am).

Docker Guidelines

  • When you edit Dockerfiles or create new ones, make sure to update data.json metadata file. This file contains all info that are used to keep track of versions and image tags via script.sh
  • Once you edited the Dockerfiles you can run ./script.sh build --verbose --no-push to build all images locally.
  • If you run into problems, run ./script.sh --help to get instructions about how to use the script.