Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task/i49 - Added copilot-hunter module + small bug fix in the runner.py file #50

Merged
merged 9 commits into from
Aug 2, 2024
Merged

task/i49 - Added copilot-hunter module + small bug fix in the runner.py file #50

merged 9 commits into from
Aug 2, 2024

Conversation

AvishaiEZen
Copy link
Collaborator

@AvishaiEZen AvishaiEZen commented Aug 2, 2024 •
edited
Loading

Fixes #49
Added copilot-hunter module + small bug fix in the runner.py file

@AvishaiEZen AvishaiEZen self-assigned this Aug 2, 2024
@AvishaiEZen AvishaiEZen linked an issue Aug 2, 2024 that may be closed by this pull request
Update Copilot Studio Hunter module and submodules #49
Closed
@AvishaiEZen
Copy link
Collaborator Author

FYI @mbrg @lanasalameh1, disregarded the following checks (ATM) and will address further later asap when possible:

  1. Black formatting check: conflicts with isort check, passed locally.
  2. Security checks for subprocess: should be checked further, currently module is based on using subprocess to call ffuf. Replaced shell=True references where possible, some still remain for calling the JS script for now to interact with the bots (need to replace with an implementation without this, WIP).

@AvishaiEZen AvishaiEZen merged commit 28c1a96 into main Aug 2, 2024
7 of 9 checks passed
@AvishaiEZen AvishaiEZen deleted the task/i49_update-copilot-studio-hunter-module-and-submodules branch August 2, 2024 15:44
@AvishaiEZen AvishaiEZen restored the task/i49_update-copilot-studio-hunter-module-and-submodules branch August 2, 2024 17:39
@AvishaiEZen AvishaiEZen deleted the task/i49_update-copilot-studio-hunter-module-and-submodules branch August 2, 2024 17:39
@AvishaiEZen AvishaiEZen mentioned this pull request Aug 2, 2024
Closed
@AvishaiEZen
Copy link
Collaborator Author

Continued here: #51

AvishaiEZen added a commit that referenced this pull request Aug 2, 2024
@AvishaiEZen
Merge pull request #53 from mbrg/task/i51_additional-changes-followin…
f44c928 
…g-pr-50

task/i50 - Additional changes to handle checks from PR #50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AvishaiEZen AvishaiEZen

Labels
task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Copilot Studio Hunter module and submodules
1 participant
@AvishaiEZen