Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support export all remote data #2344

Closed
wants to merge 4 commits into from

Conversation

chunkitmax
Copy link

Related Issue

N/A

Description

Currently, the default export functions export data loaded on the current page.
Even when exportAllData: true, the table exports the rendered remote data only (on the current page).
This patch allows it to get all remote data for export.

Additional Notes

Not sure if async/await is allow to use :)

@ollyrowe
Copy link
Contributor

Hi @chunkitmax, I'm also after this feature. May I suggest that instead of making numerous queries using the remoteDataGetter, would it make sense just to make a single request where the pageSize is equal to the totalCount property of the current query object? At the moment, if I were to have a table with the page size set to 5 and I had a total of 1000 records sitting on a remote server, then it would take 200 individual requests to get all of the data. This would most definitely take a lot of time. Apart from that, I think this is looking good. Thanks

@chunkitmax
Copy link
Author

Hi @ollyrowe, thank you for your suggestion. Yes, it should send a single request for all data.

@ollyrowe
Copy link
Contributor

ollyrowe commented Sep 7, 2020

@Domino987, is there any progress with this?

@prevostc
Copy link

Nice addition !

@stale
Copy link

stale bot commented Jan 20, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You can reopen it if it required.

@stale stale bot added the wontfix This will not be worked on label Jan 20, 2021
@robincsamuel
Copy link

Won't fix?

@stale stale bot removed the wontfix This will not be worked on label Jan 21, 2021
@stale
Copy link

stale bot commented Apr 22, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You can reopen it if it required.

@stale stale bot added the wontfix This will not be worked on label Apr 22, 2021
@Domino987
Copy link
Collaborator

Hello @robincsamuel Since mbrn is afk, we moved to material-table/core to support this library further. Please update to the new lib and see if it works for you. Thank you

@stale stale bot closed this Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting for review wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants