-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support export all remote data #2344
Conversation
Hi @chunkitmax, I'm also after this feature. May I suggest that instead of making numerous queries using the remoteDataGetter, would it make sense just to make a single request where the pageSize is equal to the totalCount property of the current query object? At the moment, if I were to have a table with the page size set to 5 and I had a total of 1000 records sitting on a remote server, then it would take 200 individual requests to get all of the data. This would most definitely take a lot of time. Apart from that, I think this is looking good. Thanks |
Hi @ollyrowe, thank you for your suggestion. Yes, it should send a single request for all data. |
915df88
to
c274aeb
Compare
…export-all-remote-data
@Domino987, is there any progress with this? |
…export-all-remote-data
Nice addition ! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You can reopen it if it required. |
Won't fix? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You can reopen it if it required. |
Hello @robincsamuel Since mbrn is afk, we moved to material-table/core to support this library further. Please update to the new lib and see if it works for you. Thank you |
Related Issue
N/A
Description
Currently, the default export functions export data loaded on the current page.
Even when
exportAllData: true
, the table exports the rendered remote data only (on the current page).This patch allows it to get all remote data for export.
Additional Notes
Not sure if async/await is allow to use :)