Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bump versions in Dockerfile #355

Merged
merged 1 commit into from
Jun 6, 2024
Merged

fix: bump versions in Dockerfile #355

merged 1 commit into from
Jun 6, 2024

Conversation

bklebe
Copy link
Contributor

@bklebe bklebe commented Jun 5, 2024

Quick fix to #354 since I forgot to update the Dockerfile.

@bklebe bklebe requested review from a team and bfauble and removed request for a team June 5, 2024 21:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Coverage of commit 7c93ebc

Summary coverage rate:
  lines......: 92.5% (1488 of 1609 lines)
  functions..: 80.8% (485 of 600 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@bklebe bklebe requested a review from dks-mbta June 6, 2024 19:19
bfauble
bfauble reviewed Jun 6, 2024
View reviewed changes
Dockerfile
@@ -27,7 +27,7 @@ RUN mix do compile, release
# Second stage: copies the files from the builder stage
FROM alpine:$ALPINE_VERSION

RUN apk add --update libssl1.1 ncurses-libs bash dumb-init libstdc++ \
RUN apk add --update libcrypto3 ncurses-libs bash dumb-init libstdc++ \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change to address CVE-2023-0464?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's just that libssl1.1 isn't available in the latest Alpine 3.20, and libcrypto3 is the listed dependency https://alpine.pkgs.org/3.19/alpine-community-aarch64/erlang-26.2.1-r0.apk.html

@bklebe bklebe merged commit fc32a88 into master Jun 6, 2024
41 checks passed
@bklebe bklebe deleted the beatrix/push/vrktmuorqyky branch June 6, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfauble bfauble bfauble approved these changes

@dks-mbta dks-mbta Awaiting requested review from dks-mbta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bklebe @bfauble