Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to ESLint and resolve lint errors #2041

Merged
merged 3 commits into from
May 3, 2024
Merged

Migrate to ESLint and resolve lint errors #2041

merged 3 commits into from
May 3, 2024

Commits on May 2, 2024

  1. chore: upgrade to NodeJS 18 

    We previously thought using Webpack 4 was an obstacle to upgrading
beyond Node 16, but it turns out there was a point release specifically
to enable it to work with later versions.
    @digitalcora
    digitalcora committed May 2, 2024
    Configuration menu
    Copy the full SHA
    28a1649 View commit details
    Browse the repository at this point in the history

  2. dev: migrate to ESLint and resolve lint errors 

    TSLint was deprecated in favor of ESLint several years ago:
palantir/tslint#4534

Additionally, running the linter has not been part of CI, so (much like
type-checking and formatting) we've accumulated many lint issues in the
code over time.

Rules where we have a huge number of outstanding issues (primarily
`no-explicit-any` and `prop-types`) are set to `warn` for the time
being, so they are still visible but won't fail CI. Remaining issues
have been cleaned up.
    @digitalcora
    digitalcora committed May 2, 2024
    Configuration menu
    Copy the full SHA
    1a3fac3 View commit details
    Browse the repository at this point in the history

  3. ci: add frontend lint check

    @digitalcora
    digitalcora committed May 2, 2024
    Configuration menu
    Copy the full SHA
    01b1cc2 View commit details
    Browse the repository at this point in the history