Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(identity): Implement GetPluginInfo #27

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Conversation

mbtamuli
Copy link
Owner

Closes #24

Before implementation

Logs from the plugin

$ make logs
emptydirclone-plugin-r9mh9 node-driver-registrar I1227 16:42:08.856290       1 main.go:135] Version: v2.9.2
emptydirclone-plugin-r9mh9 node-driver-registrar I1227 16:42:08.856322       1 main.go:136] Running node-driver-registrar in mode=
emptydirclone-plugin-r9mh9 node-driver-registrar I1227 16:42:08.856326       1 main.go:157] Attempting to open a gRPC connection with: "/csi/csi.sock"
emptydirclone-plugin-r9mh9 node-driver-registrar I1227 16:42:08.856701       1 main.go:164] Calling CSI driver to discover driver name
emptydirclone-plugin-r9mh9 node-driver-registrar E1227 16:42:08.857655       1 main.go:170] error retreiving CSI driver name: driver name is empty

After implementation

Logs from the plugin

$ make logs
emptydirclone-plugin-pljc8 node-driver-registrar I1227 16:42:31.361083       1 main.go:135] Version: v2.9.2
emptydirclone-plugin-pljc8 node-driver-registrar I1227 16:42:31.361117       1 main.go:136] Running node-driver-registrar in mode=
emptydirclone-plugin-pljc8 node-driver-registrar I1227 16:42:31.361121       1 main.go:157] Attempting to open a gRPC connection with: "/csi/csi.sock"
emptydirclone-plugin-pljc8 node-driver-registrar I1227 16:42:31.361513       1 main.go:164] Calling CSI driver to discover driver name
emptydirclone-plugin-pljc8 node-driver-registrar I1227 16:42:31.362819       1 main.go:173] CSI driver name: "emptydirclone.mriyam.dev"
emptydirclone-plugin-pljc8 node-driver-registrar I1227 16:42:31.362836       1 node_register.go:55] Starting Registration Server at: /registration/emptydirclone.mriyam.dev-reg.sock
emptydirclone-plugin-pljc8 node-driver-registrar I1227 16:42:31.362895       1 node_register.go:64] Registration Server started at: /registration/emptydirclone.mriyam.dev-reg.sock
emptydirclone-plugin-pljc8 node-driver-registrar I1227 16:42:31.362981       1 node_register.go:88] Skipping HTTP server because endpoint is set to: ""
emptydirclone-plugin-pljc8 node-driver-registrar I1227 16:42:32.348759       1 main.go:90] Received GetInfo call: &InfoRequest{}
emptydirclone-plugin-pljc8 node-driver-registrar I1227 16:42:32.361728       1 main.go:101] Received NotifyRegistrationStatus call: &RegistrationStatus{PluginRegistered:false,Error:RegisterPlugin error -- plugin registration failed with err: error adding CSI driver node info: driverNodeID must not be empty,}
emptydirclone-plugin-pljc8 node-driver-registrar E1227 16:42:32.361790       1 main.go:103] Registration process failed with error: RegisterPlugin error -- plugin registration failed with err: error adding CSI driver node info: driverNodeID must not be empty, restarting registration container.

Signed-off-by: Mriyam Tamuli <mbtamuli@gmail.com>
@mbtamuli mbtamuli merged commit f240bf1 into main Dec 27, 2023
@mbtamuli mbtamuli deleted the impl_getplugininfo branch December 27, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetPluginInfo method
1 participant