Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display a simple error message when user enters an invalid commit sha #27

Closed
buddhike opened this issue Feb 6, 2018 · 0 comments · Fixed by #30
Closed

Display a simple error message when user enters an invalid commit sha #27

buddhike opened this issue Feb 6, 2018 · 0 comments · Fixed by #30
Labels
enhancement

Comments

@buddhike
Copy link
Member

buddhike commented Feb 6, 2018

e.g. mbt describe commit fjldaf should display a simple error message than:
encoding/hex: invalid byte: U+006A 'j'
buddhike pushed a commit to buddhike/mbt that referenced this issue Feb 8, 2018
feature: User friendly errors
54ddda8 
- All errors occur within mbt lib is wrapped in an MbtError
- When creating MbtError we classify it as either ErrClassUser or ErrClassInternal
- Errors with ErrClassUser displays the minimum amount of information and
  generally operator friendly
- Errors with ErrClassInternal displays a general failure message with
  internal error details and call stack
- If you specify --debug flag to any command, even the errors with ErrClassUser
  will display the internal error details with call stack
- Also includes minor, opportunistic improvements to code
- #closes mbtproject#27
@buddhike buddhike mentioned this issue Feb 8, 2018
Merged
buddhike pushed a commit to buddhike/mbt that referenced this issue Feb 8, 2018
feature: User friendly errors
b497e91 
- All errors occur within mbt lib is wrapped in an MbtError
- When creating MbtError we classify it as either ErrClassUser or ErrClassInternal
- Errors with ErrClassUser displays the minimum amount of information and
  generally operator friendly
- Errors with ErrClassInternal displays a general failure message with
  internal error details and call stack
- If you specify --debug flag to any command, even the errors with ErrClassUser
  will display the internal error details with call stack
- Also includes minor, opportunistic improvements to code
- #closes mbtproject#27
buddhike pushed a commit that referenced this issue Feb 8, 2018
feature: User friendly errors
3167341 
- All errors occur within mbt lib is wrapped in an MbtError
- When creating MbtError we classify it as either ErrClassUser or ErrClassInternal
- Errors with ErrClassUser displays the minimum amount of information and
  generally operator friendly
- Errors with ErrClassInternal displays a general failure message with
  internal error details and call stack
- If you specify --debug flag to any command, even the errors with ErrClassUser
  will display the internal error details with call stack
- Also includes minor, opportunistic improvements to code
- #closes #27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature: User friendly errors buddhike/mbt
1 participant
@buddhike