Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to root module are not detected correctly #51

Closed
buddhike opened this issue Apr 4, 2018 · 0 comments
Closed

Changes to root module are not detected correctly #51

buddhike opened this issue Apr 4, 2018 · 0 comments
Labels

Comments

@buddhike
Copy link
Member

buddhike commented Apr 4, 2018

Which mbt command are you having troubles with?
all commands

What's the current behaviour?
When we have a module at the repository root (not a very common scenario), changes to the content in the root directory does not cause the root module to be treated as a modified.

To reproduce

mkdir test
cd test
git init 
echo "name: test" > .mbt.yml
git add -A
git commit -m "first"
git checkout -b "branch"
echo "hello" > foo
git add -A
git commit -m "second"
mbt describe pr --src branch --dst master
# returns an empty results set

What's the expected behaviour?
should display test module as modified

Environment
all environments

@buddhike buddhike added the bug label Apr 4, 2018
buddhike pushed a commit to buddhike/mbt that referenced this issue Apr 4, 2018
- Also includes the tests to cover nested module behaviour

Closes mbtproject#51
buddhike pushed a commit to buddhike/mbt that referenced this issue Apr 4, 2018
- Also includes tests to cover nested module behaviour

Closes mbtproject#51
buddhike pushed a commit that referenced this issue Apr 4, 2018
- Also includes tests to cover nested module behaviour

Closes #51
buddhike pushed a commit to buddhike/mbt that referenced this issue Apr 6, 2018
Running `mbt describe|build local` did not work
for root module.

Releated to mbtproject#51
buddhike pushed a commit that referenced this issue Apr 6, 2018
Running `mbt describe|build local` did not work
for root module.

Releated to #51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant