Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propose(303): Define a standard for commit messages. #15

Merged
merged 1 commit into from
Aug 29, 2015

Conversation

jirwin
Copy link
Collaborator

@jirwin jirwin commented Aug 29, 2015

This rule defines a standard for commit messages to be used when
proposing or amending a rule.

@mburns
Copy link
Owner

mburns commented Aug 29, 2015

I like this. I would add one more type of commit that should be standardized: judgments (rule212), for when a player is asked to resolve a disagreement over the interpretation of rules.

'Judgment' commits would be when (1) a Player files a Call For Judgment (via a Pull Request) and when (2) the Judge commits their finding on top of the original CFJ document.

Something like:

For judgments:

CFJ(<judgment number>): Short, imperative description of the CFJ

A longer description of the claim or judgment if it is needed. The short description should be limited to 80 characters or less.

Example:

CFJ(1): Player Foo violated Rule ###

I claim that Player Foo violated Rule ### when X, Y and Z occurred.

This rule defines a standard for commit messages to be used when
proposing or amending a rule.
@jirwin
Copy link
Collaborator Author

jirwin commented Aug 29, 2015

@mburns Good addition. I've updated the rule to reflect this.

@mburns
Copy link
Owner

mburns commented Aug 29, 2015

👍

1 similar comment
@jirwin
Copy link
Collaborator Author

jirwin commented Aug 29, 2015

+1

mburns added a commit that referenced this pull request Aug 29, 2015
propose(303): Define a standard for commit messages.
@mburns mburns merged commit 1dd11ac into mburns:master Aug 29, 2015
mburns added a commit that referenced this pull request Oct 2, 2020
mburns added a commit that referenced this pull request Oct 2, 2020
* #15 should have been numbered 304 originally

* PR #23 should have renumbered this

* PR #27 should have renumbered this

* update rule summaries

* ignore .DS_Store
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants