Lua Network API #1718
Merged
Lua Network API #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madmaxoft
force-pushed
the
LuaNetworkAPI
branch
5 times, most recently
from
41e05b5
to
990b86b
Compare
| @@ -355,7 +366,7 @@ class cLuaState | |||
|
|
|||
| /** Variadic template: Counting args means add one to the count of the rest. */ | |||
| template <typename T, typename... Args> | |||
| int CountArgs(T, Args... args) | |||
| int CountArgs(T &, Args &&... args) | |||
| { | |||
| return 1 + CountArgs(args...); | |||
| } | |||
There was a problem hiding this comment.
I should really replace this method with the sizeof... operator.
There was a problem hiding this comment.
I had no idea that thing existed. It could be the easiest fix.
There was a problem hiding this comment.
I'm building the change now. I only discovered it existed yesterday.
Closed
|
I'll rebase this onto current master to make it auto-mergable again. |
Also added an example in the NetworkTest plugin.
Also added an example to the NetworkTest plugin.
madmaxoft
force-pushed
the
LuaNetworkAPI
branch
from
dae14c4
to
0e769f1
Compare
| } -- Listen callbacks | ||
| end, -- fortune | ||
|
|
||
| -- TODO: Other services (fortune, daytime, ...) |
There was a problem hiding this comment.
You say other services like fortune, but it's defined right above here right?
There was a problem hiding this comment.
yea, forgot to update the comment.
|
I think this might be ready for a merge |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exported the cNetwork API to Lua, so that plugins can use it.