Added support for sending additional data in the ParticleEffect packet #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also started refactoring how broadcasts are handled
|
|
||
|
|
||
|
|
||
| bool cLuaState::IsParamNumber(int a_Param) |
There was a problem hiding this comment.
5 empty lines is the standard. Not 3, not 6, but 5 :)
|
I've fixed the style issues. |
|
Not yet, but close. I like these changes, the cBroadcaster is a nice idea. When you get this working, could you squash it all into a single commit? |
worktycho
force-pushed
the
BroadcastRefactor
branch
from
9377cdf
to
b55cc38
Compare
|
Those should be fixed now. I'll squash if CI passes. |
worktycho
force-pushed
the
BroadcastRefactor
branch
from
b55cc38
to
448df85
Compare
|
Squashed. |
madmaxoft
added a commit
that referenced
this pull request
May 7, 2015
Added support for sending additional data in the ParticleEffect packet
|
You might want to link the "email address" you use for commits to your account on GitHub |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also the start of my refactor to move Broadcasts out of cWorld.