Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove print statements before releasing on PyPi #179

Open
jochasinga opened this issue Aug 2, 2021 · 2 comments
Open

Remove print statements before releasing on PyPi #179

jochasinga opened this issue Aug 2, 2021 · 2 comments

Comments

@jochasinga
Copy link
Contributor

There is current a few places where there are still print statements. Can we switch to logger instead?

mc2/python-package/tests/azure/delete_azure_resources.py

Line 6 in bfbec91

print("Setting config file path")

@jochasinga
Copy link
Contributor Author

@chester-leung are these print statements save to remove and use logger instead?

@chester-leung
Copy link
Member

Yes, we can replace these print statements with log messages. Currently I don't believe there's a logger configured for the tests as a whole though.

@jochasinga jochasinga mentioned this issue Aug 16, 2021
Draft
jochasinga added a commit to jochasinga/mc2 that referenced this issue Aug 18, 2021
@jochasinga
Revert "Replace print statement with logger"
60c2ea4 
This reverts commit 853d481.

It's best to leave print statements in the setup script.
See also: mc2-project#179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jochasinga @chester-leung