Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-gegen- only provides support for by-able egen functions #8

Closed
felixholub opened this issue Aug 17, 2017 · 1 comment
Closed

-gegen- only provides support for by-able egen functions #8

felixholub opened this issue Aug 17, 2017 · 1 comment
Assignees
@mcaceresb
Labels
bug

Comments

@felixholub
Copy link

felixholub commented Aug 17, 2017 •
edited
Loading

I observe the following behavior of gegen on WIN 7 and Linux:


. sysuse auto
(1978 Automobile Data)

. gegen mean=mean(mpg)
-gegen- only provides support for by-able egen functions
r(198);

. by foreign: gegen mean=mean(mpg)
-gegen- only provides support for by-able egen functions
r(198);

This also happens with other gegen functions.
mcaceresb added a commit that referenced this issue Aug 17, 2017
@mcaceresb
gtools-0.6.11; fixed #8
c9456f3 
* `gegen` is callable via `by:`
* It also gives the stat for the overall group if called without a `by`
@mcaceresb
Copy link
Owner

For some reason I had commented out the lines that made gegen by-able... I fixed this. I also allow the function to be called without "by" (it now assumes it wants the overall stat). The changes are in the develop branch. When we sort out issue #9 I will merge to master.

@mcaceresb mcaceresb added the bug label Aug 17, 2017
@mcaceresb mcaceresb self-assigned this Aug 17, 2017
mcaceresb added a commit that referenced this issue Sep 13, 2017
@mcaceresb
Merge branch 'develop' for several bug fixes
feff102 
gtools-0.6.16 (2017-09-13)

* Improves the issues raised by #7
  Now the commands only fail if Stata hits the `matsize` limit (internally,
  the plugin no longer uses the `subinstr` hack to go from locals to mata
  string matrices and uses `tokens` instead, which is more appropriate;
  further, the plugin tries to set matsize to at least the number of variables
  and gives a verbose error if it fails).
* No longer crashes on Linux systems with older glibc versions.
* Fixes #14
* Should fix #12
* Fixes #9
* Fixed #8
  `gegen` is callable via `by:`; it also gives the stat for the
  overall group if called without a `by`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcaceresb mcaceresb

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcaceresb @felixholub