Add PHPDoc to facade #768
Merged
Add PHPDoc to facade #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why this PR is not merged yet? |
|
Yes its a nice improvement. But why do the checks fail for PHP7.2? |
|
@iwasherefirst2 Seems to be unrelated to my PR. This pipeline is already failing on master, see e.g. 2aebc55 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds PHPDoc methods to the facade such that IDE's can recognize the methods on the facade and provide autocompletion. This is consistent with how the Laravel framework does it. See, for example, one of their facades.