Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update quote and syn to 1.0, rust to 2018 and run cargo fmt #50

Closed
wants to merge 3 commits into from
Closed

update quote and syn to 1.0, rust to 2018 and run cargo fmt #50

wants to merge 3 commits into from

Conversation

jakobhellermann
Copy link

fixes #43

This PR will change the MSRV because quote 1.0 needs rust 1.31.

@mcarton
Copy link
Owner

mcarton commented Sep 2, 2019

Thanks, but please remove commit b9d80ad and do not run rustfmt in tests. Most of those tests are copy-pasted directly from rustc and since rustfmt wasn't used there, this change makes it harder to check the difference between the original tests and the tests included here.

Also, as specified in #43, this will require a bump to 2.0, which I am planning, but I was considering doing some other changes before.

@mcarton mcarton self-requested a review September 2, 2019 23:07
@jakobhellermann
Copy link
Author

Also, as specified in #43, this will require a bump to 2.0, which I am planning, but I was considering doing some other changes before.

Should I just leave this open and rebase when changes are made to master?

@nox
Copy link

nox commented Sep 27, 2019

Also, as specified in #43, this will require a bump to 2.0, which I am planning, but I was considering doing some other changes before.

What other changes are you planning on? Will that take time? Do you need help? It would be nice if this could land and we could live in a post-syn-1 world.

@nox
Copy link

nox commented Nov 11, 2019

derivative is one of the last crates in the Servo crate tree to still use syn 0.15. Any ETA for a new release with this PR?

@mcarton
Copy link
Owner

mcarton commented Mar 9, 2020

Sorry for the long delay! I have now merged #50 which is an update of this PR.

@mcarton mcarton closed this Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please update to syn/quote/proc-macro2 version 1.0
3 participants