This repository has been archived by the owner on Nov 19, 2023. It is now read-only.
Create an option to control whether $_SESSION would be used or not #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two reasons where this option could need to be false. 1. When sessions are disabled. This may be cli programs where the `$_SESSION` variable is undefined or just a request with no session started. 2. During testing. One may want to unit test his application with different languages. "Remembering" the language from the first run and then using it for all further requests makes this impossible. The original behaviour is preserved and saving to the session is the default behaviour. One have to explicitly add the option `saveToSession = false` to change it.
mcaskill
approved these changes
Nov 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two reasons where this option could need to be false.
When sessions are disabled. This may be cli programs where the
$_SESSIONvariable is undefined or just a request with no sessionstarted.
During testing. One may want to unit test his application with
different languages. "Remembering" the language from the first run and
then using it for all further requests makes this impossible.
The original behaviour is preserved and saving to the session is
the default behaviour. One have to explicitly add the option
saveToSession = falseto change it.