MORAY-324: client sometimes hang after a call to close()

[misterdjules]

Allows Client.prototype.close to actually abort the connection if it hasn't been established yet. Otherwise, this can lead to the issue described at https://smartos.org/bugview/MORAY-324.

Note that the newly added test will make the process running the tests suite hang when running with the current implementation. A timeout could be added to make the test fail instead.

/cc @pfmooney

[misterdjules]

@pfmooney Updated per our discussion. One thing is missing compared to what we discussed: the newly added test does not check that the number of connections is 0 when client2's 'close' event is handled.

The reason is that net.Server.getConnections returns a value that is updated when the server side of the connection handles the 'close' event, which can happen in another tick of the libuv event loop. We talked about doing that check from within a timer using a hardcoded delay. I don't like using hardcoded timeouts, which is why I haven't added that to the test, but if you think it's worth it I'm happy to add that.

[misterdjules]

Updated PR tested on OS X, Smartos with the following versions:

root@dev ~/node-fast]# uname -a
SunOS dev 5.11 joyent_20150219T102159Z i86pc i386 i86pc Solaris
[root@dev ~/node-fast]# cat /etc/pkgsrc_version 
release: 2014Q4
architecture: x86_64
[root@dev ~/node-fast]# node --version
v0.10.40
[root@dev ~/node-fast]#

and Ubuntu 12.04 with the following versions:

jgilli@ubuntu:~/dev/node-fast$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 12.04.4 LTS
Release:    12.04
Codename:   precise
jgilli@ubuntu:~/dev/node-fast$ uname -a
Linux ubuntu 3.13.0-62-generic #102~precise1-Ubuntu SMP Wed Aug 12 14:09:54 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
jgilli@ubuntu:~/dev/node-fast$ node --version
v0.10.40
jgilli@ubuntu:~/dev/node-fast$

No regression found.

[pfmooney]

Merged in 3e4ad85.

Thanks