Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTrace firing throws #3

Closed
wants to merge 1 commit into from
Closed

Conversation

karlbohlmark
Copy link

I assume you know what you're doing, so you can consider this pull request more as an illustrated question. Currently, I can not see how the dtrace firing can actually work with dtrace-provider 0.2.4 on a platform that does not support dtrace.

Anyway, I'm using this project on linux with this patch applied and since it follows the syntax in dtrace-provider's readme I don't see a reason that it should break other platforms.

Maybe you actually want to prevent it from working on a non dtrace enabled platform?

@mcavage
Copy link
Owner

mcavage commented Dec 20, 2012

Hi,

(1) It's amazing (to me, anyway) that anybody has bothered to dig into this repo ;) - it's downright hostile in terms of docs, samples, etc.

(2) Well, honestly I've never tried this repo on a Linux install, so you're probably right that it doesn't work - I did do that particular syntax on purpose, as that prevents node-dtrace-provider from doing an O(n) scan. I had done some of the work a long time ago to make node-dtrace "stub out" on Linux - I didn't realize this portion wasn't stubbed. I think the right answer is to make it stub out since it's already handling this, and then just bump the dependency version.

m

@mihai-chiorean
Copy link

same issue....

@pfmooney
Copy link
Contributor

Fixed in 6018c83.

Thanks

@pfmooney pfmooney closed this Oct 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants