Rewrite MAC parser, debug, pass compliance #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The counter `LMIC.txCnt` was not being reset at the right time; thus we sometimes treated an ACK or a POLL as a retry. With the latest changes, even more so.
Renaming makes sense, because from the LMIC's point of view, logging functions are provided by the OS/HAL. It might make further sense to move the LOG function from the compliance test script to the OS/HAL, so the logging can be used by any script without makeing them recreate the facility. On the other hand, that would make it more of a headache to override the default in the normal case.
|
This is now good enough to bring onto HEAD. With the code, we pass KR and EU compliance. Running US tests again this evening, with luck. |
terrillmoore
changed the title
Fix #382: after receiveing a message with `FHDR.FCnt.ACK` == 0, check whether we requested confirmation on the last uplink. If so, treat as a NACK and retransmit. Fix #238: Rewrite `processDnData()` to eliminate `goto`s, which were really only tail recursion and therefore both unneeded and confusing (to me, anyway).
This was referenced Aug 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change set, the LMIC passes EU compliance test V1.5 (without optional DR), and Korea compliance test V1.1, using RedwoodComm's RWC5020A and version 1.170 of the app and firmware.