-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report #58
Conversation
for more information, see https://pre-commit.ci
mccoy/workflow/rules/beast.smk
Outdated
@@ -42,6 +44,9 @@ def beast_params(wildcards): | |||
return " ".join(params) | |||
|
|||
|
|||
print(config['beast']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this debugging code? If so, can it be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes - sorry about that :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed that now
@@ -0,0 +1 @@ | |||
pybtex-format mccoy/workflow/report/bibliography.bib mccoy/workflow/report/formatted-bibliography.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the user ever need to run this script? If not then can this be moved into the noxfile (that is where all dev tasks are currently kept).
What if they use mccoy create --copy-workflow
and then want to add to the bibliography? How would the user do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, definitely. that is much better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smutch - i'm not sure how to use the noxfile. Do you have time to look at it?
The bibliography thing is just hardcoded into the report template directory. I think it will be better when my snakemake PR is folded in to the main snakemake project and then we can switch to using that. That will be more flexible and new bibliography files can be added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. You can now format the bibliography using nox -e format_bib
. I've also removed the pybtex dependency from pyproject.toml.
No description provided.