Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default behavior to print help menu #46

Merged
merged 2 commits into from
May 8, 2019

Conversation

mccurdyc
Copy link
Owner

@mccurdyc mccurdyc commented May 7, 2019

Type of Pull Request

  • api-change
  • bugfix
  • cleanup/refactor
  • design
  • documentation
  • test
  • new feature

What this PR does / why we need it:

  • update the default usage behavior to print the usage/help menu when missing required flags
  • previously, a specific error message for the missing flag was printed so the first time using neighbor could result in seeing three separate error messages until you had all required flags.

Which issue(s) this PR fixes:

Fixes #43

Any important notes for reviewers?:

Signed-off-by: Colton McCurdy <mccurdyc22@gmail.com>
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some fixes!

P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).

Signed-off-by: Colton McCurdy <mccurdyc22@gmail.com>
@mccurdyc mccurdyc merged commit 831e2a4 into master May 8, 2019
@mccurdyc mccurdyc deleted the mccurdyc/Issue#43/default-print-usage branch May 8, 2019 10:55
@mccurdyc mccurdyc restored the mccurdyc/Issue#43/default-print-usage branch June 28, 2019 12:24
@mccurdyc mccurdyc deleted the mccurdyc/Issue#43/default-print-usage branch June 28, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

print usage (with required cli flags) when missing flags
1 participant