Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching from CMD to ENTRYPOINT in docker image #85

Open
mccutchen opened this issue Oct 13, 2022 · 0 comments
Open

Consider switching from CMD to ENTRYPOINT in docker image #85

mccutchen opened this issue Oct 13, 2022 · 0 comments
Labels
breaking Tracking breaking changes that can only be made with a new major release.

Comments

@mccutchen
Copy link
Owner

As proposed by @x70b1 in #84, updating the Dockerfile to set the go-httpbin binary as the ENTRYPOINT rather than the CMD

- CMD ["/bin/go-httpbin"]
+ ENTRYPOINT ["/bin/go-httpbin"]

would be a small, useful UX improvement by allowing folks who run the image using command line arguments to slightly simplify their workflows:

-  nerdctl run mccutchen/go-httpbin go-httpbin -use-real-hostname
+  nerdctl run mccutchen/go-httpbin -use-real-hostname

I'm currently a little reluctant to do this out of fear of unexpectedly breaking existing uses in CI processes if they're not pinning to a specific release, but it's a good candidate to include in any future breaking change we need to make.

@mccutchen mccutchen added the breaking Tracking breaking changes that can only be made with a new major release. label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Tracking breaking changes that can only be made with a new major release.
Projects
None yet
Development

No branches or pull requests

1 participant