-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update golang to 1.19 #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! I'm 👍 to bump to 1.19, but unfortunately I'm not comfortable making the CMD
→ ENTRYPOINT
change for backwards-compatibility reasons.
To complete the version bump, please also update the versions in the GitHub Actions workflows:
- https://github.com/mccutchen/go-httpbin/blob/main/.github/workflows/test.yaml#L22
- https://github.com/mccutchen/go-httpbin/blob/main/.github/workflows/test.yaml#L41-L42 (we run regression tests against the previous two releases)
- https://github.com/mccutchen/go-httpbin/blob/main/.github/workflows/lint.yaml#L17
Codecov Report
@@ Coverage Diff @@
## main #84 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 6 6
Lines 961 961
=======================================
Hits 957 957
Misses 2 2
Partials 2 2 |
Ugh, looks like golangci-lint is not working w/ go 1.19. Gonna push a commit or two up here to upgrade it, too, and see what happens. We'll get this landed soon, thanks for your patience! |
🤦 or … I'll accidentally merge this when trying to push a fixup commit to this branch, how about that? |
Everything is green now, so if you don't say it that loud nobody will notice! |
I updated golang to 1.19.
Other than that I replaced
CMD
withENTRYPOINT
. This container image is a very good example for the difference between booth settings. You can now use theCMD
for command line options. Example: