Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang to 1.19 #84

Merged
merged 4 commits into from
Oct 17, 2022
Merged

Update golang to 1.19 #84

merged 4 commits into from
Oct 17, 2022

Conversation

x70b1
Copy link
Contributor

@x70b1 x70b1 commented Oct 12, 2022

I updated golang to 1.19.

Other than that I replaced CMD with ENTRYPOINT. This container image is a very good example for the difference between booth settings. You can now use the CMD for command line options. Example:

 nerdctl run mccutchen/go-httpbin -use-real-hostname

@x70b1 x70b1 changed the title update golang, replace CMD Update golang to 1.19, replace CMD with ENTRYPOINT Oct 12, 2022
Copy link
Owner

@mccutchen mccutchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I'm 👍 to bump to 1.19, but unfortunately I'm not comfortable making the CMDENTRYPOINT change for backwards-compatibility reasons.

To complete the version bump, please also update the versions in the GitHub Actions workflows:

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2022

Codecov Report

Merging #84 (3430fe8) into main (6740230) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files           6        6           
  Lines         961      961           
=======================================
  Hits          957      957           
  Misses          2        2           
  Partials        2        2           

@x70b1 x70b1 changed the title Update golang to 1.19, replace CMD with ENTRYPOINT Update golang to 1.19 Oct 13, 2022
@mccutchen
Copy link
Owner

Ugh, looks like golangci-lint is not working w/ go 1.19. Gonna push a commit or two up here to upgrade it, too, and see what happens. We'll get this landed soon, thanks for your patience!

@mccutchen mccutchen merged commit 3430fe8 into mccutchen:main Oct 17, 2022
@mccutchen
Copy link
Owner

🤦 or … I'll accidentally merge this when trying to push a fixup commit to this branch, how about that?

@x70b1
Copy link
Contributor Author

x70b1 commented Oct 17, 2022

how about that?

Everything is green now, so if you don't say it that loud nobody will notice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants