-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve service support, + miscellaneous changes #32
Conversation
mazunki
commented
Jun 28, 2024
- write pidfile when running daemon
- add logger info to pidfile
- catch SIGHUP signal to reload config during runtime
- use dist/ for packaging purposes
- add openrc service
- autoconf ignore
- organize files, support autoconf
- change some flags to subcommands
- ignore wheels
- change entry point to main
- update documentation
- update tests. permission denied claims 2==1?
whoops, i didn't mean to request a merge for this yet, since it's a bit bundled together and out of order. was too quick on running i initially started working on adding support for pidfile because that makes service managers happy, and one thing led to another lol. while i haven't changed any implementation behaviour, this PR is a breaking change. commands are no longer flags, for instance. i believe i have documented all the new things, though. if i missed something, please let me know. i realize this PR would be best split into two different PRs, sorry about that. let me know if something should be changed :) changes:
|
i think it would be wise to update and aggregate to the tests too. i only updated the tests which already existed |
Cool I'll take a look, sorry was out on vacation this week, so haven't kept up with GH. |
|
||
|
||
# Executable files | ||
The executable files are contained within amdfan. This directory is a python module, and can either be loaded as `python -m amdgpu`. If you want to import the module, you may be interested in checking out `amdfan.commands`, which contains most of the subcommands. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The executable files are contained within amdfan. This directory is a python module, and can either be loaded as `python -m amdgpu`. If you want to import the module, you may be interested in checking out `amdfan.commands`, which contains most of the subcommands. | |
The executable files are contained within amdfan. This directory is a python module, and can either be loaded as `python -m amdfan`. If you want to import the module, you may be interested in checking out `amdfan.commands`, which contains most of the subcommands. |
Looks good, I'll have to pull it down to make sure I can still build it for the Arch packaging, and to make sure it still works with my py3status-amdfan, I'll likely just have to modify some of the commands on the widget side of things. |
and fix the broken tests, will have to redo how the commands are put togther, however this will work for now.
since typing.Self was introduced in 3.11 not going to deal with backports
Oh, lovely, thanks for merging it. :) Sorry about the delay myself, I have been AFK too. Is there anything left to do/change? I know the tests should probably be updated... but that's probably for another time. It seems you got the PKGBUILD covered? If you think it's ready, I will bump the ebuild for Gentoo on ::guru too. |
yeah I fixed at least the existing tests, so that the right cli funcs are passed so we no longer have the 2 == 1 etc. The rest of the changes were just to make it work with the github workflow build. |