Fix ras-mc-ctl bug and add support for parsing the new fields added to MCE tracepoint #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 26, 2024 00:46
Currently, the mcastatus_msg string of struct mce_event is added to the SQLite database by the rasdaemon when it is recording errors. The same however, is not outputted by the ras-mc-ctl utility. The string provides important error information relating to the received MCE. For example, on AMD SMCA systems, the string outputs extended error code and description. As such, the string should be present in the output of ras-mc-ctl utility. Add support to output the string through the ras-mc-ctl utility. Signed-off-by: Avadhut Naik <avadhut.naik@amd.com>
Support for exporting the PPIN (Protected Processor Inventory Number) is being added to the mce_record tracepoint. Add the required, corresponding support in the rasdaemon for the field to be parsed and logged or added to the database and viewed later through ras-mc-ctl utility. Signed-off-by: Avadhut Naik <avadhut.naik@amd.com>
Support for exporting the Microcode Revision is being added to the mce_record tracepoint. Add the required, corresponding support in the rasdaemon for the field to be parsed and logged or added to the database and viewed later through ras-mc-ctl utility. Signed-off-by: Avadhut Naik <avadhut.naik@amd.com>
AvaNaik
changed the title
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set fixes an issue with ras-mc-ctl utility and adds support in the rasdaemon to parse the PPIN and Microcode fields which are now being exported through the MCE tracepoint (link below).
The first patch fixes the ras-mc-ctl utility issue in which even though the mcastatus_msg string is being added to the database by the rasdaemon, the same is not outputted by the utility.
The second patch adds support to parse the PPIN field of MCE tracepoint. The patch also supports storing the field in the SQLite database and outputting through ras-mc-ctl utility.
The third patch adds support to parse the Microcode field of MCE tracepoint. The patch also supports storing the field in the SQLite database and outputting through ras-mc-ctl utility.
The three patches are being submitted as a set since patches 2 and 3 might encounter conflicts in merging without patch 1.
Link for the PPIN and Microcode fields added to the MCE tracepoint:
https://lore.kernel.org/linux-edac/20240401171455.1737976-1-avadhut.naik@amd.com/T/#mec02926ae30a92161160a2f9649b9e2b419701c0