Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation doesn't work for a delay of more than 1000 (ms) #25

Closed
dmahajan980 opened this issue Oct 12, 2019 · 6 comments
Closed

Animation doesn't work for a delay of more than 1000 (ms) #25

dmahajan980 opened this issue Oct 12, 2019 · 6 comments

Comments

@dmahajan980
Copy link

I've using the library for 2-3 days and I observed that if the data-sal-delay property is set to a value greater than 1000 then the animation doesn't work.

@mciastek
Copy link
Owner

Can you prepare a working demo of this issue? You can use CodeSandbox as a working environment.

@JSR-FR
Copy link

JSR-FR commented Nov 6, 2019

The same is happening to me with the most basic use of sal. There's definitely an issue on data-sal-delay with value greater than 1000.

@zamson
Copy link

zamson commented Nov 13, 2019

For me the animation works but fires with no delay at all

@dmahajan980
Copy link
Author

dmahajan980 commented Nov 14, 2019

Yes, for a data-sal-delay value greater than 1000 the delay doesn't work but the animations do.

@mciastek
Copy link
Owner

@dmahajan980 is right. Maximum value of the delay is 1000ms (1s), so you can't have a delay more than that. Probably it hasn't been stated in docs. If you want to specify higher delay, you can use custom CSS, like:

.custom-animated[data-sal-delay] {
  transition-delay: 2s;
}

For now it should be enough.

There's a request of adding support for custom animation properties using CSS variables. Probably that's the right way of handling such cases.

@mciastek
Copy link
Owner

Closing this issue in favour of #27. See docs for more details. If your target browser doesn't support CSS variables follow the example presented in #25 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants