Improve Arena doc and reduce visible code #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcimadamore
reviewed
Nov 9, 2022
| @@ -74,14 +75,18 @@ | |||
| * can be {@linkplain MemorySession#isAccessibleBy(Thread) accessed} by multiple threads. This might be useful when | |||
| * multiple threads need to access the same memory segment concurrently (e.g. in the case of parallel processing). | |||
| * Moreover, a shared arena can be closed by any thread. | |||
| * @implSpec | |||
There was a problem hiding this comment.
This is a good point - but is only true for allocate I think? For close we need to make sure that owner thread is respected. So perhaps more specific implSpec on these two methods might do the job?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes improved doc for Arena and moves code segments to the internals.