Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Demo] Update features example dashboard with selectors #333

Merged
merged 14 commits into from
Feb 28, 2024

Conversation

huong-li-nguyen
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen commented Feb 26, 2024

Description

  • Adds a page with all selectors in the control panel on the left (as Filter only) to the features demo dashboard
  • Consolidates all docstrings inside selectors
  • Fix CSS for table pagination

Screenshot

Screenshot 2024-02-26 at 18 10 32

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@huong-li-nguyen huong-li-nguyen changed the title Demo/add selectors [Demo] Update features example dashboard with selectors Feb 26, 2024
@huong-li-nguyen huong-li-nguyen self-assigned this Feb 26, 2024
@huong-li-nguyen huong-li-nguyen added the Feature Request 🤓 Issue contains a feature request label Feb 26, 2024
@huong-li-nguyen huong-li-nguyen linked an issue Feb 26, 2024 that may be closed by this pull request
1 task
Copy link
Contributor

@petar-qb petar-qb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome as usual! 🧹 🚀

vizro-core/examples/features/app.py Outdated Show resolved Hide resolved
vizro-core/examples/features/yaml_version/app.py Outdated Show resolved Hide resolved
Copy link
Contributor

@nadijagraca nadijagraca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 🚀

Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think we should improve the Slider example if easy to do so, but no worries if not.

vizro-core/examples/features/app.py Outdated Show resolved Hide resolved
vizro-core/examples/features/app.py Show resolved Hide resolved
vizro-core/examples/features/app.py Outdated Show resolved Hide resolved
Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! If I could choose, I would probably work more with a graph, and ideally actually only one component, but that may be tough with fitting all the options in.

vizro-core/examples/features/app.py Outdated Show resolved Hide resolved
vizro-core/src/vizro/static/css/table.css Show resolved Hide resolved
@huong-li-nguyen
Copy link
Contributor Author

Lgtm! If I could choose, I would probably work more with a graph, and ideally actually only one component, but that may be tough with fitting all the options in.

Yeah, that's what I had before, but it did not work well if we want to have all selectors on one page 😄 They are contradicting each other / intersecting - which made the interactions horrible with one graph.

@huong-li-nguyen huong-li-nguyen enabled auto-merge (squash) February 28, 2024 11:50
@huong-li-nguyen huong-li-nguyen merged commit 30369d6 into main Feb 28, 2024
33 checks passed
@huong-li-nguyen huong-li-nguyen deleted the demo/add_selectors branch February 28, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request 🤓 Issue contains a feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation Enhancement
5 participants