Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Set upper limit on dash temporarily #341

Merged
merged 5 commits into from
Mar 4, 2024
Merged

[Bug] Set upper limit on dash temporarily #341

merged 5 commits into from
Mar 4, 2024

Conversation

huong-li-nguyen
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen commented Mar 4, 2024 •
edited
Loading

Description

See this for context: plotly/dash#2778

This is supposed to be a temporary solution only such that merging PRs is not blocked. Still waiting for feedback from @l0uden or dash

Screenshot

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@huong-li-nguyen huong-li-nguyen changed the title [Bug] Set an upper limit on Dash temporarily [Bug] Set upper limit on dash temporarily Mar 4, 2024
@huong-li-nguyen huong-li-nguyen self-assigned this Mar 4, 2024
@huong-li-nguyen huong-li-nguyen added the Bug Report 🐛 Issue contains a bug report label Mar 4, 2024
@huong-li-nguyen huong-li-nguyen marked this pull request as ready for review March 4, 2024 12:01
antonymilne
antonymilne requested changes Mar 4, 2024
View reviewed changes
vizro-core/pyproject.toml Outdated Show resolved Hide resolved
maxschulz-COL
maxschulz-COL approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, we should ideally not release before this is fixed imo

vizro-core/changelog.d/20240304_123956_huong_li_nguyen_add_upper_limit.md Show resolved Hide resolved
@l0uden l0uden self-requested a review March 4, 2024 12:50
@antonymilne
Update vizro-core/changelog.d/20240304_123956_huong_li_nguyen_add_upp…
c12a20b 
…er_limit.md

Signed-off-by: Antony Milne <49395058+antonymilne@users.noreply.github.com>
@huong-li-nguyen huong-li-nguyen enabled auto-merge (squash) March 4, 2024 13:26
@huong-li-nguyen huong-li-nguyen merged commit 1114b9d into main Mar 4, 2024
33 checks passed
@huong-li-nguyen huong-li-nguyen deleted the bug/add_upper_limit branch March 4, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0uden l0uden l0uden approved these changes

@antonymilne antonymilne antonymilne approved these changes

@maxschulz-COL maxschulz-COL maxschulz-COL approved these changes

@Joseph-Perkins Joseph-Perkins Awaiting requested review from Joseph-Perkins Joseph-Perkins is a code owner

@Anna-Xiong Anna-Xiong Awaiting requested review from Anna-Xiong

@petar-qb petar-qb Awaiting requested review from petar-qb

Assignees

@huong-li-nguyen huong-li-nguyen

Labels
Bug Report 🐛 Issue contains a bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@huong-li-nguyen @l0uden @antonymilne @maxschulz-COL