-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tidy] Replace html.Div
with dbc.Card
#373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. The only thing I'm not quite sure about is whether we want to add this to changelog.md
Yeah, good question. I am not sure either, we could also just not mention it.
|
Good question, and I am not sure my thoughts on this are always consistent. I would maybe propose this guideline:
Now do I care about the returned components library type as a user? --> Generally no, but it could be a little bit like the CSS entry, some users may care if they use properties of the component?? Would maybe leave out. In general we do not want to too lengthy changelogs, as they dilute focus. Wdyt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Changing the underlying component library shouldn't have an effect on the user, as our model field arguments do not change. Visually they look the same more or less (not pixel perfect). So let me remove the changelog entry of that 👍 I could add an entry on the renaming of CSS classNames (this will happen more frequently though, but if we are fine with that - ok 👍 ). At some point this will all switch to the classNames that Bootstrap uses. |
Description
html.Div
withdbc.Card
Screenshot
Jumping effect previously disappeared and is now fixed again:
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":