Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix CSS for floatingFilter in AgGrid #388

Merged
merged 7 commits into from
Mar 26, 2024

Conversation

huong-li-nguyen
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen commented Mar 26, 2024

Description

As already discussed, I think we need to evaluate on a case-by-case basis whether we fix the relevant CSS or whether the user needs to add the CSS themselves. In general, the default ag-grid theme should look fine without having to apply any custom CSS (e.g. the datepicker looks different than ours, but it looks fine still). The disadvantage of trying to cover every case is that our custom CSS grows and at some point gets difficult to maintain, because our overwrites might conflict. Long-term wise we should probably create a proper Figma design for the ag-grid, but that's currently not in the scope.

In this case, I agree we should fix it, as otherwise it's completely misaligned and it doesn't add much CSS.

Screenshot

Screenshot 2024-03-26 at 12 56 09

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@huong-li-nguyen huong-li-nguyen self-assigned this Mar 26, 2024
@huong-li-nguyen huong-li-nguyen linked an issue Mar 26, 2024 that may be closed by this pull request
1 task
Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! I would even add this as a fix to the fixed section. It definitely makes a difference to users. Thanks for taking care of this 🙏

Copy link
Contributor

@nadijagraca nadijagraca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. 🚀

@huong-li-nguyen huong-li-nguyen enabled auto-merge (squash) March 26, 2024 12:41
@huong-li-nguyen huong-li-nguyen merged commit 62a26e7 into main Mar 26, 2024
34 checks passed
@huong-li-nguyen huong-li-nguyen deleted the bug/add_css_floatingfilter branch March 26, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report 🐛 Issue contains a bug report
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS of AG Grid floatingFilter option buggy
3 participants