-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
20 wifi support - Initial Work #22
Conversation
Retooled the cmake configuration such that the hardware library is now an INTERFACE library, rather than directly modifying the root project. This allows us to remove numerous link_lib defs from the cli and root project, as well as provides an easier method to pass hardware-level compiler definitions up to the main project in the cases where that is necessary.
…sions of FreeRTOS
@Kintar - I'm finally back in front of a screen and taking a look at this. First off great work hammering on this and getting something functional. A few comments right off the bat:
That's as far as I've gotten from reading your code from a phone screen. Thanks again. Will be in touch shortly. |
20-wifi-support branch is up to date with your other CYW43 library/LED changes. Use that as your upstream, rebase and update your PR and we can work off that as a feature branch. |
Welcome back, @mcknly! I hope the self-punative bike ride was a success. ;)
Looking forward to hearing more from you! |
I've also changed the title of this PR. Since we have a feature branch, tagging it as "NON FUNCTIONAL" seems a tad redundant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nit-picky things to fix before merging into the feature branch, otherwise I will forget I was thinking of them.
Well, that was a wild journey, and it's still not QUITE working. At this point, the wifi connection works, but the NVM system fails to initialize.
I've done quite a few things in this branch, let me give a quick overview:
There's still an issue with the watchdog forcing a reboot occasionally, and wifi intermittently fails to connect if the watchdog restarts the system.
Also, I still can't get the _async version of the wifi connection to function correctly, so the wifi service uses a blocking connect call, although this doesn't actually block the RTOS, just that task.