Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new index.html #77

Closed
paulvickers opened this issue Jul 31, 2023 · 21 comments
Closed

Add new index.html #77

paulvickers opened this issue Jul 31, 2023 · 21 comments

Comments

@paulvickers
Copy link
Collaborator

The previous one turned out to have some unmatched tags. Sorry! Can we try this version please?

@mcolburn
Copy link
Owner

mcolburn commented Jul 31, 2023 via email

@paulvickers
Copy link
Collaborator Author

Hmmm. How much control will Doxa give me over layout (fonts, responses next to/below actors, cover pages, etc.)? Might it be worth reverting back to the index.html that did work?

You will also see from the email I sent that there is a problem with the Romanian text entry. The template seems to be putting en_UK_durlash keys into the Romanian version rather than ro_UK_dur.

@mcolburn
Copy link
Owner

mcolburn commented Aug 1, 2023 via email

@mcolburn
Copy link
Owner

mcolburn commented Aug 1, 2023

I pushed the latest index.html. The editor seems to be OK. Please verify. However, the generator still hangs. I will see if I can find an obvious reason.

@paulvickers
Copy link
Collaborator Author

Thanks, Michael. I pushed one more up 20 mins or so ago which had a minor change.

@mcolburn
Copy link
Owner

mcolburn commented Aug 1, 2023

I pushed to OLW. I am trying to get a debugger going on my dev for OLW to see if I can spot an obvious reason for why the generator hangs. Intellij Idea's debugger has stopped working on my code and can't figure out why. I just now got Visual Studio Code to work debugging java. So, perhaps in a few hours I will know what the problem is.

@paulvickers
Copy link
Collaborator Author

I just spotted one empty (of text) key pair in the index.html which I have now removed (just below the heading of the Holy Anaphora):

<tr>
<td class='leftCell'><span class='kvp' data-key='properties_gr_GR_cog|media.key'><span class='media-group-empty'></span></span>
</td>
<td class='rightCell'><span class='kvp' data-key='properties_en_US_goa|media.key'><span class='media-group-empty'></span></span> </td>
</tr>

@mcolburn
Copy link
Owner

mcolburn commented Aug 1, 2023 via email

@paulvickers
Copy link
Collaborator Author

ok, just that in the editor it shows up as properties ~ media.key

@mcolburn
Copy link
Owner

mcolburn commented Aug 1, 2023 via email

@paulvickers
Copy link
Collaborator Author

Ah, I see.

Is it worth me replacing all the uk_durlash domain tags with us_goa do you think?

@mcolburn
Copy link
Owner

mcolburn commented Aug 1, 2023 via email

@mcolburn
Copy link
Owner

mcolburn commented Aug 1, 2023 via email

@paulvickers
Copy link
Collaborator Author

Weird that it should suddenly begin doing that. It couldn't be anything to do with large comment blocks, could it?

@paulvickers
Copy link
Collaborator Author

Might it be worth putting back in the last version of index.html that didn't throw an error? If it works, I could then clean that one up to remove the mismatched tags & domains.

@mcolburn
Copy link
Owner

mcolburn commented Aug 2, 2023 via email

@paulvickers
Copy link
Collaborator Author

Bless you, Michael. I hope this parsing issue helps with Doxa too...
I still need to make a couple more tweaks to the template (there are some ChoirL and ChoirR instances that I just want to be Choir) so will upload a new version of index.html later. I hope this won't cause any further issues for you.

@mcolburn
Copy link
Owner

mcolburn commented Aug 2, 2023 via email

@paulvickers
Copy link
Collaborator Author

Thanks again. I've pushed what I hope is the final index.html to the repo. I decided to replace all Choir IDs with People IDs.

@mcolburn
Copy link
Owner

mcolburn commented Aug 2, 2023 via email

@paulvickers
Copy link
Collaborator Author

Perfect, thanks! I'll close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants