Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation and validation work #19

Closed
GlenTiki opened this issue Jun 24, 2016 · 2 comments
Closed

Documentation and validation work #19

GlenTiki opened this issue Jun 24, 2016 · 2 comments

Comments

@GlenTiki
Copy link
Collaborator

Currently, the documentation doesn't show how to customise the headers on the request.

For the duration option, browsing the code, it is required, but never checked, @mcollina, should we put a check in for the duration and test it, or default it to some value, eg. 10? Obviously, this will need a unit test and documentation work, too.

Supported HTTP methods should be documented.

Show the default value for the http pipelining value.

Update the .track doc, I left outputStream listed as a param name when I should have listed opts.

@mcollina
Copy link
Owner

Go ahead with doc and validations.

@mcollina
Copy link
Owner

IMHO connections and duration should always be specified, but Dave would like to have defaults

GlenTiki added a commit to GlenTiki/autocannon that referenced this issue Jun 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants