Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forever option fails from second iteration onwards #482

Open
LRagji opened this issue Mar 12, 2023 · 1 comment
Open

Forever option fails from second iteration onwards #482

LRagji opened this issue Mar 12, 2023 · 1 comment

Comments

@LRagji
Copy link

LRagji commented Mar 12, 2023

It seem like when you run with forever option the first iteration works perfectly fine but the next ones just gets sort-circuited and cancelled cause of this line which in my debugging opinion should be like this line which executes all iteration correctly....

again I am no expert on this repo, so excuse me if I am wrong

@LRagji
Copy link
Author

LRagji commented Mar 12, 2023

There is one other change we have to add this line numRunning = opts.connections to restart function at line 171 cause at line 280 which is identifies running connections is decrementing it so a restart will need to reset this variable...

I think we need more testing with permutation combinations for forever option.

LRagji pushed a commit to LRagji/autocannon that referenced this issue Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant