Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix JSON array body on CLI #414

Merged
merged 1 commit into from
Dec 23, 2021
Merged

fix: Fix JSON array body on CLI #414

merged 1 commit into from
Dec 23, 2021

Conversation

silverwind
Copy link
Contributor

Fixes: #413

mcollina
mcollina approved these changes Dec 16, 2021
View reviewed changes
Copy link
Owner

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@silverwind
Copy link
Contributor Author

silverwind commented Dec 16, 2021 •
edited
Loading

By the way: I did not explore the option to replace subarg with minimist (which I think is the proper solution), because I saw subarg's context feature being in active use, so the replacement would be a breaking change (thought it's one I'd be willing to take).

@mcollina mcollina merged commit 20f6c47 into mcollina:master Dec 23, 2021
@silverwind silverwind deleted the array branch December 24, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't send JSON array as body
2 participants
@silverwind @mcollina