Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be a disruptive one, as we will need to change some API.
As LevelUp is going to remove WriteStream support from it, I think we should do it too.
The current WriteStream implementation only use is by LevelGraph-N3 to import huge loads of triples. In order to do so, LevelGraph uses level-writestream, a WriteStream alternative that can handle multiple concurrent batches: https://npmjs.org/package/level-writestream. That breaks the atomicity of putting all indexes in a single batch, but it's extremely efficient for write loads.
In the browser, having any WriteStream in will just increase the package size.
putStream
but leverage the new module, and/or a different solution.join()
andjoinSearch()
, which were deprecated in favor ofsearch()
and searchStream()`)Any opinions? Consider this as a proposal, any volunteers for any of this?