Changed release behavior #6
Conversation
- Edited released to release (as it is a function) - More importantly, drain the queue when it is filled! Caused issues in aedes, see moscajs/aedes#88
|
There seem to be issues. Let me check what's wrong. (Thanks CI 👍) |
|
Can you add also a unit test? |
|
Okay, I finally see why released is released - it is integrated in fastparallel. I'm reverting the name changes and the tests are back up again. I'll start working on a unit test. |
Remove one from the queue first, before adding one. Changed fastparallel released property to work with the release function. Confusing names, huh? TODO: fix unit test.
It was right the first time. Reverting this. I'm adding a unit test to prevent this from happening again.
I removed the old 'queue concurrency' and replaced it with this one. Please review this change! These unit tests functionalities are added: - Check whether queue order is OK - Check whether queue is emptied correctly
|
This took somewhat longer than expected. Could you review the change on the 'queue concurrency' unit test? I replaced it because it failed, and the test seemed erroneous because it tested asynchronously while the problems were synchronous. I'm not 100% sure it should have failed to begin with. IMO the new tests should do this correctly. |
|
The overall reason why we have a If the queue is not being drained correctly it's a probably a bug in some Aedes code. |
|
cc @GavinDmello |
|
Oh, wow, you are right. This limits the queue to 150 instead of limiting the concurrency. |
Caused issues in aedes, see moscajs/aedes#88