Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url_callback config + specs #18

Merged
merged 1 commit into from
Oct 7, 2017
Merged

url_callback config + specs #18

merged 1 commit into from
Oct 7, 2017

Conversation

AlessandroMinali
Copy link
Contributor

@AlessandroMinali AlessandroMinali commented Oct 6, 2017

Config as global fallback:

cli = LocaSMS::Client.new 'LOGIN', 'PASSWORD', url_callback: 'http://example.com/callback

Per request callback:

cli.deliver 'my message', '1199998888,5500002222', url_callback: 'http://unique.com/callback'

cli.deliver_at 'my message', '2013-10-12 20:33:00', '1155559999', url_callback: 'http://another.com/callback'

#16

Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

.rubocop.yml: Style/AccessModifierIndentation has the wrong namespace - shoul...
.rubocop.yml: Style/AccessModifierIndentation has the wrong namespace - should be Layout
.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
.rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLineBetweenDefs has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLinesAroundClassBody has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLinesAroundModuleBody has the wrong namespace - should be Layout
.rubocop.yml: Style/FirstParameterIndentation has the wrong namespace - should be Layout
.rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout
.rubocop.yml: Style/IndentHash has the wrong namespace - should be Layout
.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceAroundBlockParameters has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceAroundEqualsInParameterDefault has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceBeforeBlockBraces has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout
.rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout
.rubocop.yml: Style/ExtraSpacing has the wrong namespace - should be Layout
.rubocop.yml: Style/AlignArray has the wrong namespace - should be Layout
.rubocop.yml: Style/BlockEndNewline has the wrong namespace - should be Layout
.rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout
.rubocop.yml: Style/ElseAlignment has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLinesAroundAccessModifier has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLinesAroundMethodBody has the wrong namespace - should be Layout
.rubocop.yml: Style/EndOfLine has the wrong namespace - should be Layout
.rubocop.yml: Style/IndentationConsistency has the wrong namespace - should be Layout
.rubocop.yml: Style/IndentArray has the wrong namespace - should be Layout
.rubocop.yml: Style/LeadingCommentSpace has the wrong namespace - should be Layout
.rubocop.yml: Style/MultilineBlockLayout has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceAfterColon has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceAfterMethodName has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceAfterNot has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceAfterSemicolon has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceBeforeComma has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceBeforeComment has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceBeforeSemicolon has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceInsideBrackets has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceInsideRangeLiteral has the wrong namespace - should be Layout
.rubocop.yml: Style/Tab has the wrong namespace - should be Layout
.rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout
.rubocop.yml: Lint/Eval has the wrong namespace - should be Security
.rubocop.yml: Lint/SpaceBeforeFirstArg has the wrong namespace - should be Layout
Error: The `Style/TrailingComma` cop no longer exists. Please use `Style/TrailingCommaInLiteral` and/or `Style/TrailingCommaInArguments` instead.
(obsolete configuration found in .rubocop.yml, please update it)
The `Rails/DefaultScope` cop no longer exists.
The `Style/SingleSpaceBeforeFirstArg` cop has been renamed to `Layout/SpaceBeforeFirstArg`.
The `Style/SpaceAfterControlKeyword` cop has been removed. Please use `Layout/SpaceAroundKeyword` instead.
The `Style/SpaceBeforeModifierKeyword` cop has been removed. Please use `Layout/SpaceAroundKeyword` instead.
The `Style/MethodCallParentheses` cop has been renamed to `Style/MethodCallWithoutArgsParentheses`.
The `Style/DeprecatedHashMethods` cop has been renamed to `Style/PreferredHashMethods`.
obsolete parameter RunRailsCops (for AllCops) found in .rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter IndentWhenRelativeTo (for Layout/CaseIndentation) found in .rubocop.yml
`IndentWhenRelativeTo` has been renamed to `EnforcedStyle`
obsolete parameter AlignWith (for Lint/EndAlignment) found in .rubocop.yml
`AlignWith` has been renamed to `EnforcedStyleAlignWith`
obsolete parameter AlignWith (for Lint/DefEndAlignment) found in .rubocop.yml

Copy link
Member

@adilsoncarvalho adilsoncarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally! This is a long time awaiting feature. Kudos @AlessandroMinali 🎉

@adilsoncarvalho adilsoncarvalho merged commit 1e7c44e into mcorp:master Oct 7, 2017
@adilsoncarvalho adilsoncarvalho mentioned this pull request Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants