Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battleship gameplay basic #7

Merged
merged 34 commits into from
Aug 23, 2020
Merged

Battleship gameplay basic #7

merged 34 commits into from
Aug 23, 2020

Conversation

mcrd25
Copy link
Owner

@mcrd25 mcrd25 commented Aug 20, 2020

What is accomplished

his game is very basic and not perfect in User Experience (This would be worked on)

  • It has 3 main noon-UI components
    • Ship
    • GameBoard
    • Player
      These components are the core of the app and the UI builds upon these.
  • The user can only currently place ship based on coordinates (would change in future)
  • A player can only play against the computer ( which is not very smart)

Hope to finally wrap this project. As you can see I started last year, but never completed it! 😢

Copy link

@Torres-ssf Torres-ssf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes required 💪

Hi @mcrd25
Awesome job on this project. The system created by you it's pretty impressive, It allows players to select their ship positions. 👏 👏 🎉
But before moving on we need to work on some changes.

  • Microverse has switched from the stickler to Github actions as it described here. We need to apply that change to your project 😄
    The Github Actions instructions can be found here
    You can safely delete the .stickler files

  • There is bug in the game right. The game does not end after the user destroys all computer's ships. It keeps going on till the point the computer destroys all user's ships.
    Screenshot from 2020-08-20 12-10-18

  • It seems the src/UI/gameplay.js file is empty. We can safely delete it.

Feel free to message me on slack if you have any questions 😄
Happy Coding 💻
Sergio Torres
Twitter LinkedIn Portifolio

Copy link

@Ispirett Ispirett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status approved 👍

Great job @mcrd25 fixing the issues and building this project 👍

please fix the typos in your readme file like "his is a game" and "noon-ui" before merging.

@mcrd25
Copy link
Owner Author

mcrd25 commented Aug 23, 2020

@Ispirett I don't see the typos

@mcrd25 mcrd25 merged commit ddbba71 into development Aug 23, 2020
@mcrd25 mcrd25 deleted the battleship branch August 23, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants