-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Battleship gameplay basic #7
Conversation
correct feature branch issue
Final Game implementation
Create LICENSE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes required 💪
Hi @mcrd25 ✋
Awesome job on this project. The system created by you it's pretty impressive, It allows players to select their ship positions. 👏 👏 🎉
But before moving on we need to work on some changes.
-
Microverse has switched from the stickler to Github actions as it described here. We need to apply that change to your project 😄
The Github Actions instructions can be found here
You can safely delete the.stickler
files -
There is bug in the game right. The game does not end after the user destroys all computer's ships. It keeps going on till the point the computer destroys all user's ships.
-
It seems the
src/UI/gameplay.js
file is empty. We can safely delete it.
Feel free to message me on slack if you have any questions 😄
Happy Coding 💻
Sergio Torres
Twitter LinkedIn Portifolio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Status approved 👍
Great job @mcrd25 fixing the issues and building this project 👍
please fix the typos in your readme file like "his is a game" and "noon-ui" before merging.
@Ispirett I don't see the typos |
What is accomplished
his game is very basic and not perfect in User Experience (This would be worked on)
These components are the core of the app and the UI builds upon these.
Hope to finally wrap this project. As you can see I started last year, but never completed it! 😢