Fix for UTF-8 encoding error (and some other tweaks)... #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storage of personal API token is moved into separate file, using .gitignore to prevent its inclusion in the repository
Occasional error was encountered due to mismatch of string encoding, which is fixed my explicitly encoding all retrieved text to UTF-8.
|
Thanks, looks great. |
mcs07
added a commit
that referenced
this pull request
Nov 25, 2013
Fix for UTF-8 encoding error (and some other tweaks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm reissuing this pull request, as I've realised I wasn't approaching it quite right with my branching etc!
Hey there,
This is the first time I've even tried the whole 'pull request' thing, so excuse me if I don't know the conventions!
Anyway, I found your code very useful, and have made a few tweaks I thought might by worth merging into the main repository. (I found your code through the ChemSpider website.)
I hit some error messages related to encodings when retrieving information from the database, which were fixed by explicitly encoding all the retrieved text into UTF-8.
I've also added the init.py to allow it to be imported as a module, and have moved the private token definition into a separate (git ignored) file, to make storing that easier inside the repository.
Hope that all makes sense!
Cheers,
Nick Fyson