-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide for non-console recovery uart #1576
provide for non-console recovery uart #1576
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commits will need a sign-off-by line, and I recommend configuring git so that your email has your full name, rather than a shortened handle. You'll need to do an interactive rebase, and use git commit --amend --reset-author
to fix the author, once you have changed the git configuration.
My email doesn't have my full name, it is just what it is. Can you please
provide more detailed instructions for these comments (assuming they apply
to me)
…On Wed, Feb 22, 2023 at 10:42 AM David Brown ***@***.***> wrote:
***@***.**** requested changes on this pull request.
The commits will need a sign-off-by line, and I recommend configuring git
so that your email has your full name, rather than a shortened handle.
You'll need to do an interactive rebase, and use git commit --amend
--reset-author to fix the author, once you have changed the git
configuration.
—
Reply to this email directly, view it on GitHub
<#1576 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXMDFXAROM64RFEGT2FKD33WYYXX3ANCNFSM6AAAAAAT2RDFEE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This is very similar to this PR #1155 right? |
It is set within git, and the username can be set to whatever you want. As far as adding the signed off by, that can be done by either inserting the text into the commit message manually, or passing |
@de-nordic can you take a look at this? |
I would rather go with #1155, because I do not want to introduce MCUboot chosen, while this is Zephyr specific code, and we have the chosen for MCUmgr anyway. If we want to have the MCUboot chosen, it should be used as override for zephyr chosen. |
#1155 went in, is this PR still relevant? |
@brian-level Ping regarding #1576 (comment). |
#1155 works for me, even though it seems silly that it uses "zephyr" specific since this has nothing to do with zephyr |
In some situations such as having multiple CPUs where one can upgrade another, it is nice to allow for a second UART to use mcuboot serial recovery while (for example) keeping the console on the first.
This change allows someone to specify a recovery UART to use other than chosen zephyr-console by adding to a device tree as in the examples below
chosen {
mcuboot-recovery-uart=&uart1;
};
If not specified, the chosen zephyr-console uart will be used